Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[ISV-5221] Add new step to inject and push SBOMs in build-ima… #1565

Closed
wants to merge 4 commits into from

Conversation

rcerven
Copy link
Contributor

@rcerven rcerven commented Nov 1, 2024

…ge-index task."

This reverts commit 05cb676.

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

reverting it because it is causing problems with results limit, since it added more steps

Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are causing the Tekton results to overflow since new steps results in a smaller space for results in each task step.

@arewm
Copy link
Member

arewm commented Nov 1, 2024

/retest

@arewm arewm enabled auto-merge November 1, 2024 19:53
@arewm arewm added this pull request to the merge queue Nov 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 1, 2024
@arewm arewm enabled auto-merge November 2, 2024 01:15
@arewm arewm added this pull request to the merge queue Nov 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 2, 2024
@arewm arewm enabled auto-merge November 4, 2024 01:37
@arewm arewm added this pull request to the merge queue Nov 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 4, 2024
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like stronger proof that the problem was the result limit. Have you tested with the affected user that this resolves the issue?

@chmeliik
Copy link
Contributor

chmeliik commented Nov 4, 2024

I would like stronger proof that the problem was the result limit. Have you tested with the affected user that this resolves the issue?

Probably no need to bother. The affected user was using an older version of the task, this change wasn't even included. We can probably close this.

@arewm arewm closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants